[omniORB] compiler warnings?

[Duncan Grisby]

On Tuesday 11 December, Dan Kegel wrote:

> "idlc.cc":159:  (defined _ISOC99_SOURCE || defined _ISOC9X_SOURCE        || (defined __STDC_VERSION__ && __STDC_VERSION__ >= 199901L))
> 
>                                                    ^--- expecting )

This warning is from omkdepend. It's not very bright, so it complains
about some things. It doesn't do any harm. If someone want to fix it,
that would be nice, but the chances are it will be killed off with the
(so far mythical) new build system.

[...]
> I assume these are spurious; my system does indeed have Python 1.5.2 
> (which comes standard with red hat 7.2)

Those are also spurious complaints from omkdepend.

> ../typecode.cc:4704: warning: `PR_unionDiscriminator lbl_value' might
> be used uninitialized in this function

If you look at the code, you'll see that it can't be used
uninitialised. The compiler just isn't clever enough to figure it out.

> ../../omniIdentity.h:98: warning: `class omniIdentity' has virtual
> functions but non-virtual destructor

This is intentional. There is no requirement in C++ that a class with
virtual functions has a virtual destructor. The classes in question
are only ever deleted by their most derived class, so it does not
cause a problem.

> ../request.cc: In method `void *RequestImpl::invoke ()':
> ../request.cc:334: warning: `int fwd' might be used uninitialized in
> this function
> ../request.cc: In method `void *RequestImpl::send_oneway ()':
> ../request.cc:541: warning: `int fwd' might be used uninitialized in
> this function

These warnings are also spurious. The variables are never used
uninitialised.

Cheers,

Duncan.

-- 
 -- Duncan Grisby  \  Research Engineer  --
  -- AT&T Laboratories Cambridge          --
   -- http://www.uk.research.att.com/~dpg1 --