[omniORB] Re: [omniORB-dev] [RFC] reverting ABI change in sslContext introduced in 4.1.2

[Duncan Grisby]

On Thursday 3 April, Thomas Girard wrote:

> while preparing Debian packages for omniORB4 4.1.2, we noticed the
> following change in include/omniORB4/sslContext.h:
> 
> class sslContext {
> private:
> // ...
>   SSL_CTX*          pd_ctx;
>   omni_tracedmutex* pd_locks;
>   CORBA::Boolean    pd_ssl_owner;   <-- this attribute was added
> };
> 
> According to [1], to make a binary compatible change in C++, you can't:
>   "add new data members to a class or change order of data members in a
>    class (doesn't apply to static ones)"

You are right. The change should not have been made.

However, now that it has been changed, I think it is just as bad to
revert it, since that's another incompatible ABI change. We just need to
be more careful in future.

Duncan.

-- 
 -- Duncan Grisby         --
  -- duncan at grisby.org     --
   -- http://www.grisby.org --