[omniORB] memory leak in omniORB-4.1.x

[Serguei Kolos]

Hi

I believe I have found a memory leak in the omniORB-4.1.6 (which exists 
also in the previous
versions). The 2 patches to fix the leak are attached. Below is the 
description of the problem.

The giopServer class maintains the list of connectionState objects for 
each opened connection,
but the issue is that objects are never removed from that list, even if 
a connection is closed.
This happens because the removal may occur only if the condition in the 
giopServer.cc:1172
line is met:

          if (Link::is_empty(cs->workers))

But that actually never happens as the "workers" attribute of the 
connectionState class is used
in rather weird way - this is a list which keeps accumulating workers 
each time a new worker is
used for the given connection but no workers are ever removed from that 
list, so it never becomes
empty. In general the other problem is that the "workers" list is not 
really used in the code in
any way so it seems that it may go saving some memory and CPU cycles, 
and this is what
the attached patches are doing.

Cheers,
Sergei

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: giopServer.cc.patch
URL: <http://www.omniorb-support.com/pipermail/omniorb-list/attachments/20121026/962686df/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: giopServer.h.patch
URL: <http://www.omniorb-support.com/pipermail/omniorb-list/attachments/20121026/962686df/attachment-0001.ksh>