[omniORB] #define typo in include/omniORB4/cdrStream.h

[Raschick, Hartmut]

Hello Duncan,
in $subject::quotedLocation there seems to be a typo:

<snip>
inline void
unmarshalArrayDouble(_CORBA_Double* a, int length)
{
    get_octet_array((_CORBA_Char*) a, length * 8, omni::ALIGN_8);

    if (unmarshal_byte_swap()) {

#  if defined(<RED>Has_Longlong</RED>) && !defined (OMNI_MIXED_ENDIAN_DOUBLE)
      _CORBA_ULongLong* p=(_CORBA_ULongLong*)a;
      for( int i = 0; i < length; i++ ) {
        p[i] = byteSwap(p[i]);
      }
#  else
<snap>

We believe, the text in "<RED></RED>" should rather be "HAS_LongLong"... like so:

<snip>
#  if defined(HAS_LongLong) && !defined (OMNI_MIXED_ENDIAN_DOUBLE)
<snap>

...seeing that only that is ever defined (and/or otherwise used).

cheers,
hardy

Mit freundlichen Grüßen / Best regards

Hartmut Raschick
Network Management Solutions
-----------------------------------
KEYMILE GmbH
Wohlenbergstr. 3
D-30179 Hannover, Germany

Phone: +49 (0)511 6747-564
Fax:   +49 (0)511 6747-777
mailto:Hartmut.Raschick at keymile.com
http://www.keymile.com

<< KEYMILE - because connectivity matters >>

Geschäftsführer: Rolf Unterberger, Jay Bratz - Rechtsform der Gesellschaft: GmbH, Sitz: Hannover - HRB 208 693, Amtsgericht Hannover, USt-Id. Nr.: DE 301 700 778; WEEE-Reg.-Nr.: DE 5933 6750
Managing Directors: Rolf Unterberger, Jay Bratz - Legal structure: GmbH, Registered office: Hanover - HRB 208 693, Local court Hanover, VAT-Reg.-No.: DE 301 700 778, WEEE-Reg.-No.: DE 5933 6750