[omniORB] omniORB 4.3: chokes on default configuration file

[Thomas Braun]

Hello,

I'm trying to get my large application [1] running with omniORB 4.3.

As it did not work out of the box I realized, after some testing, that
I can repoduce the problem with an shipped example.

System:
- Debian 10 (buster)
- x64
- r6529 on branches/4_3

Steps to reproduce:
- compile and install omniORB
- cp sample.cfg to /etc/omniORB.cfg
- cd src/examples
- make
- cd echo
- ./eg1

gives

omniORB: (0) 2020-08-28 21:21:55.252509: ORB_init failed: Bad parameter
(2097152    # 2 MBytes.) for ORB configuration option giopMaxMsgSize,
reason: Invalid value, exp
ect n >= 8192 or n == 0

Caught CORBA::INITIALIZE


The problem is the value for giopMaxMsgSize in the config file, as the
parser does not ignore trailing whitespace and comments and can then
not parse the value into a number.

Fixing the configuration file via

$svn diff sample.cfg  
Index: sample.cfg
===================================================================
--- sample.cfg  (Revision 6535)
+++ sample.cfg  (Arbeitskopie)
@@ -98,7 +98,7 @@

 #
 #    Valid values = (n >= 8192)
 #

-giopMaxMsgSize = 2097152    # 2 MBytes.
+giopMaxMsgSize = 2097152

  
 ####################################################################
 # strictIIOP flag


does solves the immediate issue, but I can not judge, if that is the
correct thing to do.

Thomas

[1]: https://github.com/tango-controls/cppTango/